Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[mkldnn-1.0]Fix reorder2default #16608

Closed

Conversation

ZhennanQin
Copy link
Contributor

As #16602

@pengzhao-intel @TaoLv

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Change-Id: Iae5043fd1c105af38c877be47559383b35dd9ae1
@TaoLv
Copy link
Member

TaoLv commented Oct 24, 2019

Could you please take a look at the failing tests? I notice #16602 was merged to master branch. Do you want us to merge this PR or rebase mkldnn-v1.0 to master branch? I'm afraid merging both will cause conflicts when rebasing mkldnn-v1.0 branch.

@ZhennanQin
Copy link
Contributor Author

@TaoLv Previously I thought we only need to merge this PR. As master PR is merged, Let's change this to a rebase of master.

@ZhennanQin ZhennanQin closed this Oct 24, 2019
@ZhennanQin ZhennanQin deleted the fix_reorder2default_1.0 branch October 28, 2019 02:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants